Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(layers): Trim Top of Pyramids #633
base: main
Are you sure you want to change the base?
feat(layers): Trim Top of Pyramids #633
Changes from 7 commits
c578eb7
3a79102
711c4be
f69ef20
2ea8f61
46e3fd3
914b4f9
b61e5fb
f1a49e1
2aa66ad
d1232ae
5975a51
1b7f4b8
768d014
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, I seem to remember adding padding to tiles from the loaders. It seems like we are just reversing that here? Perhaps this warrants a change to the loaders?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this was also my first instinct but I don't think we do anymore after you found that specific WebGL setting for controlling of what number the textures should be a multiple, which we set to 1.