Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: fix git push in the docs workflow #346

Merged
merged 2 commits into from
Jan 17, 2024
Merged

infra: fix git push in the docs workflow #346

merged 2 commits into from
Jan 17, 2024

Conversation

maximlt
Copy link
Contributor

@maximlt maximlt commented Jan 17, 2024

I previously set up permissions in the pr_flow workflow which propagate to the workflow it calls. When a PR is merged, the docs workflow runs on its own, it needs additional permissions to push to the repo. Note that setting one permission disables all the other ones (see https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs), so I had to explicitly allow writing to pull-requests too. Let's see!

Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

@maximlt maximlt merged commit e3a09d8 into main Jan 17, 2024
7 checks passed
@maximlt maximlt deleted the fix_gitpush_docs branch October 8, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant