Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the full PR modernization checklist template with a link to wiki #420

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

droumis
Copy link
Contributor

@droumis droumis commented Aug 29, 2024

Since the NF SDG is done, the modernization checklist is more of an optional resource and may be confusing to show the whole thing without context

Since the NF SDG is done, the modernization checklist is more of an optional resource and may be confusing to show the whole thing without context
@droumis droumis requested a review from maximlt August 29, 2024 15:16
Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

@maximlt
Copy link
Contributor

maximlt commented Sep 3, 2024

Agree with that. Do you want to put the sentence you added as a Markdown comment (<!-- foo -->)? I don't have any strong preference.

Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.

@maximlt maximlt merged commit 0419694 into main Oct 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants