Improve World cup dashboard #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR. |
hoxbro
approved these changes
Jan 20, 2025
|
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #485
Finding a little bit darker green for the header. According to my preferences the current one is too light, it "screams" in your eyes and does not have a modern look.
Removing the card background in the main layout (main_layout=None).
Using a color for the bar chart that works nicely with the green colors on the pitch. Either a green or other color. The current blue does not look modern.
Setting main_max_width="1000px" or similar to center the main content and limit its width. Set to "800px"
Make the bar and pitch plots stretch_width
Put the top widgets into a row instead of as now a column to take up less space enabling users to seen everything in the current window. This didn't fully solve the issue though.
Align the image in the sidebar center
Not use a header (#) for the text in the sidebar as this turns it into an anchor link which is confusing when hovering over it.
Speed up the deployed application. It feels slow. Maybe the server needs more compute or ram. Maybe by adding caching or using a faster data backend.
The deployed app is not slow at all from my end so I'm not sure how I can improve on it.
Here's how the app looks now: