Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh!: Drop Python 3.9 #1399

Merged
merged 4 commits into from
Jan 28, 2025
Merged

enh!: Drop Python 3.9 #1399

merged 4 commits into from
Jan 28, 2025

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jan 28, 2025

resolves #1392

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.98%. Comparing base (864836b) to head (198051a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1399      +/-   ##
==========================================
- Coverage   88.51%   85.98%   -2.53%     
==========================================
  Files          93       93              
  Lines       18750    18749       -1     
==========================================
- Hits        16597    16122     -475     
- Misses       2153     2627     +474     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro
Copy link
Member Author

hoxbro commented Jan 28, 2025

The missing coverage is related to the spatialpandas test no longer being run. They are skipped because they only support the legacy implementation.

Ref issue: holoviz/spatialpandas#146

Copy link
Collaborator

@amaloney amaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amaloney amaloney merged commit cc753d2 into main Jan 28, 2025
11 of 12 checks passed
@amaloney amaloney deleted the drop_python_39 branch January 28, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drop Python 3.9
2 participants