Set the bounds of the kdims
List parameter
#5667
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just ran the unit test suite of HoloViews with Param installed from holoviz/param#605 and a few tests failed. They failed when
kdims
List
is overridden in a sub Parameterized class, and the overridingList
is not defining explicitly the newbounds
. In the current state of Param (1.x) ,bounds
is not inherited from any super class but is always the default of(0, None)
(meaning a list of any length). With the tested PRbounds
is inherited.The change made in this PR was to set explicitly the
bounds
in the subclasses. Alternatively, one could have loosenbounds
in the super classes. The commits list what change was made and why. For instance, one could have setbounds
ofChart.kdims
(super class) to(0, None)
instead of updatingbounds
onSpikes.kdims
(sub class) to(0, None)
. I didn't spend much time thinking about doing the alternativeI noticed there are a few typos in the commits, here are the changes made:
(0,None)
toSpikes.vdims
to overrideChart.vdims
bounds of(1, None)
(3,3)
toPath3D.vdims
to overrideGeometry.vdims
bounds of(2, 2)
(3,3)
toScatter3D.vdims
to overrideGeometry.vdims
bounds of(2, 2)
(3,3)
toTriSurface.vdims
to overrideGeometry.vdims
bounds of(2, 2)