Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Accordian active_header_background in dark theme #7576

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Dec 26, 2024

Closes #7575

Closed:
image

Opened:
image

@ahuang11 ahuang11 changed the title Fix accordion theme Fix Accordian active_header_background in dark theme Dec 26, 2024
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.12%. Comparing base (ad154df) to head (3c52e24).
Report is 11 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7576       +/-   ##
===========================================
+ Coverage   71.90%   82.12%   +10.21%     
===========================================
  Files         338      340        +2     
  Lines       51441    51483       +42     
===========================================
+ Hits        36990    42280     +5290     
+ Misses      14451     9203     -5248     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr
Copy link
Member

The arrow should be white or at least lighter.

@philippjfr
Copy link
Member

Would be great to revive this with the other dark mode fixes!

@ahuang11
Copy link
Contributor Author

ahuang11 commented Jan 7, 2025

image image

(note, this PR didn't cause the mismatch between card and accordion styling; this is on main):
image

@philippjfr philippjfr merged commit 2c2a2eb into main Jan 8, 2025
18 checks passed
@philippjfr philippjfr deleted the fix_accordion_theme branch January 8, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accordian active_header_background is not being set in dark theme
2 participants