Fix azure oauth issues #7587
Merged
Fix azure oauth issues #7587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcSkovMadsen
commented
Jan 5, 2025
| @@ -54,6 +54,7 @@ def decode_response_body(response): | |||
| body = codecs.decode(response.body, 'ascii') | |||
| except Exception: | |||
| body = codecs.decode(response.body, 'utf-8') | |||
| body = re.sub("\'", '\\"', body) | |||
There was a problem hiding this comment.
This is a workaround as just below you replace both " and '. It works. But its hard to do right as there are no existing test cases explaining what the other re.sub are handling.
MarcSkovMadsen
commented
Jan 5, 2025
| @@ -450,10 +451,17 @@ def _raise_error(self, response, body=None, status=400): | |||
| log.warning(f"{provider} OAuth provider failed to fully " | |||
| f"authenticate returning the following response:" | |||
| f"{body}.") | |||
| if hasattr(body, "get"): | |||
There was a problem hiding this comment.
In my case body was None due to the decoding error triggering an AttributeError.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7587 +/- ##
==========================================
+ Coverage 82.11% 82.22% +0.11%
==========================================
Files 340 341 +1
Lines 51483 51562 +79
==========================================
+ Hits 42273 42398 +125
+ Misses 9210 9164 -46 ☔ View full report in Codecov by Sentry. |
philippjfr
approved these changes
Jan 13, 2025
philippjfr
approved these changes
Jan 13, 2025
This was referenced Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing #7586 and more issues identified while trying to get azure oauth working.