Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate version.py #1002

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Deprecate version.py #1002

wants to merge 3 commits into from

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Jan 3, 2025

Implements #999

There are probably fancier ways to implement that but I think that will do the job.

@jlstevens
Copy link
Contributor

Looks good to me!

I think the main thing we need to check is that nothing in holoviz is using param.Version before the next version of param is released. That way, this warning should only be seen by non-holoviz users of Version of which I suspect there aren't that many (if any).

@maximlt
Copy link
Member Author

maximlt commented Jan 14, 2025

I think the main thing we need to check is that nothing in holoviz is using param.Version before the next version of param is released. That way, this warning should only be seen by non-holoviz users of Version of which I suspect there aren't that many (if any).

True! #999 lists some projects that depend on param/version.py. param/version.py is usually used at both the build and run times, which means that ideally, projects should migrate before we release Param with this deprecation warning. Let's merge it when it's done for the most important ones.

  • Migrate the main projects (list TBD) using param/version.py to alternative solutions

@maximlt maximlt marked this pull request as draft January 14, 2025 13:24
@maximlt maximlt added this to the v2.3.0 milestone Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants