Add Notification model and handle notification event #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase to solve the merge conflict. |
|
@raman325 maybe use the same logic to fire the event ? I can adjust my PR so it will also forward these events ? |
raman325
force-pushed
the
notifications
branch
from
9450bb4 to
1bb29cf
Compare
|
The event data will be different but otherwise yeah that makes sense. I was thinking it would be nice eventually to tie these events to the primary "entity" but that might be easier said than done. |
|
Entities don't fire events, besides the built in state changed events, in Home Assistant. |
MartinHjelmare
approved these changes
Feb 1, 2021
|
sure I meant add entity_id as part of the event data to use as criteria for automations |
|
We can discuss that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I plan to submit a PR similar to home-assistant/core#45729 where we fire an event when a notification is received for a node.