Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add myself as codeowner for amazon_polly #119189

Merged
merged 2 commits into from
Jun 9, 2024

Conversation

jschlyter
Copy link
Contributor

@jschlyter jschlyter commented Jun 9, 2024

Proposed change

Take code owner of the amazon_polly integration. I use Polly myself and I'd be happy to take care of it.

I'm the maintainer of the Charge Amps integration for Home Assistant (available via HACS) as well as several other Python modules.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed small-pr PRs with less than 30 lines. labels Jun 9, 2024
@jschlyter jschlyter marked this pull request as draft June 9, 2024 07:31
@jschlyter jschlyter marked this pull request as ready for review June 9, 2024 08:58
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jschlyter 👍

../Frenck

@frenck frenck merged commit f32b29e into home-assistant:dev Jun 9, 2024
20 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2024
@jschlyter jschlyter deleted the adopt_amazon_polly branch June 23, 2024 07:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants