Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump incomfort backend library to v0.6.0 #119207

Merged
merged 1 commit into from
Jun 9, 2024
Merged

Bump incomfort backend library to v0.6.0 #119207

merged 1 commit into from
Jun 9, 2024

Conversation

jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Jun 9, 2024

Breaking change

The boyer status, based on the boylers display code or fault code, and has been refactored to be slugified and unique, so we can start supporting localization:
jbouwh/incomfort-client#15

Automations or scripts depending on the old status texts might break. Users need to check their automations and scripts to make sure they do not break.

Proposed change

Bumps the incomfort-client backend library to v0.6.0

Release: https://github.com/jbouwh/incomfort-client/releases/tag/v0.6.0-1
Changelog**: jbouwh/incomfort-client@0.5.0...v0.6.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed dependency deprecation Indicates a breaking change to happen in the future integration: incomfort small-pr PRs with less than 30 lines. by-code-owner Quality Scale: No score labels Jun 9, 2024
@jbouwh jbouwh added breaking-change and removed deprecation Indicates a breaking change to happen in the future labels Jun 9, 2024
@jbouwh jbouwh requested a review from joostlek June 9, 2024 13:03
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jbouwh 👍

../Frenck

@frenck frenck merged commit 34f20fc into dev Jun 9, 2024
38 checks passed
@frenck frenck deleted the bump-incomfort-client branch June 9, 2024 13:52
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants