Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump thermopro-ble to 0.11.0 #137381

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

stephan48
Copy link
Contributor

@stephan48 stephan48 commented Feb 5, 2025

Proposed change

This PR updates the thermopro_ble dep to v0.11.0(add the set_datetime business/device communication logic to thermopro-ble.) as a prerequesite of PR #135740

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Feb 5, 2025

Hey there @bdraco, @h3ss, mind taking a look at this pull request as it has been labeled with an integration (thermopro) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of thermopro can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign thermopro Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bdraco
Copy link
Member

bdraco commented Feb 5, 2025

Thanks for bumping the dependency! Please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.
    This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks 👍

@bdraco bdraco changed the title update component.thermopro dep thermopro_ble Bump thermopro-ble to 0.11.0 Feb 5, 2025
@bdraco bdraco marked this pull request as draft February 5, 2025 00:06
@bdraco
Copy link
Member

bdraco commented Feb 5, 2025

Marking as draft so review comments can be addressed. Please mark as ready when completed.

@stephan48
Copy link
Contributor Author

stephan48 commented Feb 5, 2025

Ah sorry, i initially added the link to the release at the bottom where the checkbox was, moved them and added the other requested informations!

@stephan48 stephan48 marked this pull request as ready for review February 5, 2025 00:13
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bdraco bdraco added the smash Indicator this PR is close to finish for merging or closing label Feb 5, 2025
@bdraco bdraco merged commit c965dfb into home-assistant:dev Feb 5, 2025
46 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed dependency integration: thermopro Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants