Add config flow to media extractor #32590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
has-parent
20 tasks
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
# Conflicts: # source/_integrations/media_extractor.markdown
c0ffeeca7
requested changes
May 27, 2024
| - **best**: Best video + audio stream | ||
| - **bestaudio[ext=m4a]**: Best audio stream with m4a extension | ||
| - **worst**: Worst video + audio stream | ||
| - **bestaudio[ext=m4a]/bestaudio[ext=ogg]/bestaudio**: Best m4a audio, otherwise best ogg audio and only then any best audio |
There was a problem hiding this comment.
Do you mean OGG file format?
| Query examples with explanations: | ||
|
|
||
| - **bestvideo**: Best video only stream | ||
| - **best**: Best video + audio stream |
There was a problem hiding this comment.
What do you mean by best? High resolution?
There was a problem hiding this comment.
out of scope for this PR I guess.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: c0ffeeca7 <[email protected]>
c0ffeeca7
reviewed
May 29, 2024
| Query examples with explanations: | ||
|
|
||
| - **bestvideo**: Best video only stream | ||
| - **best**: Best video + audio stream |
There was a problem hiding this comment.
out of scope for this PR I guess.
home-assistant
bot
removed
the
parent-merged
frenck
added
the
cherry-picked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add config flow to media extractor
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.