-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: template variables #583
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #583 +/- ##
==========================================
+ Coverage 75.36% 75.69% +0.33%
==========================================
Files 87 87
Lines 7420 7510 +90
==========================================
+ Hits 5592 5685 +93
+ Misses 1471 1469 -2
+ Partials 357 356 -1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Jason Harley <[email protected]>
Co-authored-by: Jason Harley <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made some changes to the test file that are a bit annoying to read. I pulled the "errors when they should" t.Run
out of the main test and into individual tests that have descriptive names about what exactly is being tested as the number of validations/tests was getting a bit unwieldy
This looks great, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, one note about a needed docs addition ✨
docs/resources/webhook_recipient.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
variable
needs to be added as an argument below template
Short description of the changes
Support webhook recipient template variables in Terraform