Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dummy app #16

Merged
merged 1 commit into from
Aug 14, 2016
Merged

Add a dummy app #16

merged 1 commit into from
Aug 14, 2016

Conversation

courajs
Copy link
Contributor

@courajs courajs commented Aug 13, 2016

Takes most of the app code from #7, but puts it in the right place, and sets up configuration correctly. No acceptance tests yet, but I've made some progress.

@courajs courajs mentioned this pull request Aug 13, 2016
@gr2m
Copy link
Member

gr2m commented Aug 13, 2016

This is great, thanks @courajs! I wonder, can we still add an npm start script that starts the dummy app for manual debugging and fiddling around? That'd be great :) But that could be another issue and we can merge this in first.

@courajs
Copy link
Contributor Author

courajs commented Aug 14, 2016

ember start does start the dummy app :)

The app folder is what gets added to the app of any app consuming this addon. The dummy app is what gets served by ember serve inside an addon project, and what is available during acceptance tests. It consumes the addon itself by default, which is why it was showing up anyway when added to the app folder.

@courajs courajs merged commit 3b53190 into master Aug 14, 2016
@courajs courajs deleted the aaron-dummy-app branch August 14, 2016 16:21
@gr2m
Copy link
Member

gr2m commented Aug 14, 2016

thanks for the explanation, this is great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants