Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap xy coordinate if custom tms url is used #2136

Closed

Conversation

Sujanadh
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

MBtiles and PMtiles were failing when custom tms url was used.

Describe this PR

We need to swap xy co ordinate if custom tms url is used. So, this PR checks whether custom tms url is provided or not. If provided it swaps xy coordinate.

Screenshots

Please provide screenshots of the change.

Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@Sujanadh Sujanadh self-assigned this Jan 31, 2025
@github-actions github-actions bot added bug Something isn't working backend Related to backend code labels Jan 31, 2025
@Sujanadh
Copy link
Collaborator Author

This is small fix only for tokha instance so mistakely raised PR here going to close it

@Sujanadh Sujanadh closed this Jan 31, 2025
@spwoodcock
Copy link
Member

Each TMS is unique - there is no agreed upon standard if the XY should be reversed or not, so we can't have a general rule in place.

Either:

  • We extract from the URL placeholders provided and set automatically.
  • Its user configurable.
  • We have something more complex, like attempt a download for both and see which one succeeds, then continue.

@spwoodcock
Copy link
Member

Actually no need to address this though, as long as its fixed for Tokha πŸ‘

basemapper will be replaced with other options in the near future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants