Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented: support to unArchive archived rules (#386) #388

Merged
merged 5 commits into from
Nov 29, 2024

Conversation

amansinghbais
Copy link
Contributor

@amansinghbais amansinghbais commented Nov 27, 2024

Related Issues

#386

Short Description and Why It's Useful

  • Added a line item on the rules list page to show the count of archived rules.
  • Implemented a modal to unarchive archived rules.

Note: This Pr is dependent upon new oms release since we need to add status transition record as follows:
<moqui.basic.StatusFlowTransition statusFlowId="Default" statusId="ATP_RULE_ARCHIVED" toStatusId="ATP_RULE_ACTIVE" transitionName="Archived to Active"/>

Screenshots of Visual Changes before/after (If There Are Any)

Screenshot from 2024-11-27 11-48-17
Screenshot from 2024-11-27 11-53-00

Contribution and Currently Important Rules Acceptance

Copy link
Contributor

@ymaheshwari1 ymaheshwari1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the data related to status transition in the PR and also mention the same in the issue.

src/components/ArchivedRuleItem.vue Show resolved Hide resolved
src/components/ArchivedRuleModal.vue Outdated Show resolved Hide resolved
src/views/SafetyStock.vue Outdated Show resolved Hide resolved
src/components/ArchivedRuleItem.vue Outdated Show resolved Hide resolved
src/components/ArchivedRuleModal.vue Outdated Show resolved Hide resolved
src/views/SafetyStock.vue Outdated Show resolved Hide resolved
@ymaheshwari1 ymaheshwari1 merged commit ef6a97e into hotwax:main Nov 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants