Improved: used for loop instead of promise for sync api calls (#616)

hotwax · Jan 23, 2025 · 56780d6 · 56780d6
1 parent c22d9b5
commit 56780d6
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/src/components/DownloadClosedCountModal.vue b/src/components/DownloadClosedCountModal.vue
@@ -219,9 +219,9 @@ async function fetchBulkCycleCountItems() {
   }
 
   if(!counts.length) return [];
-  let countItems = [] as any;
+  let countItems = [] as any, count = {} as any;
 
-  const responses = await Promise.allSettled(counts.map(async (count: any) => {
+  for(count of counts) {
     let items = [] as any, resp, index = 0;
     try {
       do {
@@ -237,12 +237,9 @@ async function fetchBulkCycleCountItems() {
       logger.error(err)
     }
 
-    return items
-  }))
+    countItems = countItems.concat(items);
+  }
 
-  responses.map((response: any) => {
-    if(response.status === "fulfilled") countItems = countItems.concat(response.value);
-  })
   return countItems
 }