Improved: Added CSS to make the scrolling of the job configuration section independent of the job list(#762) #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction independent of the job list(hotwax#762)
dt2patel
requested changes
Jan 24, 2025
src/views/Pipeline.vue
Outdated
| /* Added CSS styles to the <aside> element to occupy 80% of the viewport height, enable vertical scrolling for overflowing content, | ||
| hide the scrollbar, and add bottom padding for spacing */ | ||
| aside { | ||
| height: 80vh; |
There was a problem hiding this comment.
we can't use a fixed number here. Need to take approach similar to my MR where I used 100% height of parent container.
…e elements, and introduced isFetchingMoreJobs flag to prevent multiple API calls(hotwax#762) - Disabling ion-content scrolling to prevent interference with main scrolling. - Enabling main scrolling to allow independent scrolling of main content. - Setting heights of main and aside elements to prevent overflow and ensure seamless scrolling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#762
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance