Implemented: Added application layer services to create a sales order in the system. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patelanil
reviewed
Jan 1, 2025
| <set field="orderContext.orderName" from="orderJson.name"/> | ||
| <set field="orderContext.salesChannelEnumId" from="orderJson.salesChannelEnumId"/> | ||
| <set field="orderContext.orderDate" from="orderJson.createdAt"/> | ||
| <set field="orderContext.currencyUomId" from="orderJson.currencyUom"/> |
There was a problem hiding this comment.
We don't have the concept of presentmentCurrencyUomId.
There was a problem hiding this comment.
OrderHeader has been extended with presentmentCurrencyUom field and it is being stored in legacy. Default ProductStore currency is stored in OrderHeader.currencyUom field. Same is true for OrderPaymentPreference and it also involves unnecessary UOM conversion. I think we should not use the extended fields and Uom conversion and just store Shopify's presentment amount and currency.
arunpati
reviewed
Jan 2, 2025
arunpati
reviewed
Jan 2, 2025
mridulpathak
reviewed
Jan 2, 2025
mridulpathak
reviewed
Jan 2, 2025
- Removed create#PostalAddress service and used similar service in ContactMechServices.xml. - Created a new create#Person service and used while creating customer.
…, updated the input param name and minor code imrpovements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specification Document: https://github.com/saastechacademy/foundation/blob/main/project-ideas/order-ledger/ShopifyOrderSyncDesign.md