Skip to content

Commit

Permalink
Merge pull request #332 from amansinghbais/273-Po-title
Browse files Browse the repository at this point in the history
Improved: enhanced the text for pending and completed items label in PO details page (#273)
  • Loading branch information
ymaheshwari1 authored Feb 21, 2024
2 parents 07e960f + c22c454 commit b2199fe
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions src/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"Click the backdrop to dismiss.": "Click the backdrop to dismiss.",
"Complete": "Complete",
"Completed": "Completed",
"COMPLETED: ITEM": "COMPLETED: {itemsCount} ITEM",
"COMPLETED: ITEMS": "COMPLETED: {itemsCount} ITEMS",
"Completed: item": "Completed: {itemsCount} item",
"Completed: items": "Completed: {itemsCount} items",
"Confirm": "Confirm",
"Copied": "Copied { value }",
"Close purchase order items": "Close purchase order items",
Expand Down Expand Up @@ -56,8 +56,8 @@
"ordered": "ordered",
"Orders not found": "Orders not found",
"Password": "Password",
"PENDING: ITEM": "PENDING: {itemsCount} ITEM",
"PENDING: ITEMS": "PENDING: {itemsCount} ITEMS",
"Pending: item": "Pending: {itemsCount} item",
"Pending: items": "Pending: {itemsCount} items",
"primary identifier": "primary identifier",
"Primary Product Identifier": "Primary Product Identifier",
"Proceed": "Proceed",
Expand Down
8 changes: 4 additions & 4 deletions src/views/PurchaseOrderDetail.vue
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@

<ion-item lines="none">
<ion-label v-if="getPOItems('pending').length > 1" color="medium" class="ion-margin-end">
{{ translate("PENDING: ITEMS", { itemsCount: getPOItems('pending').length }) }}
{{ translate("Pending: items", { itemsCount: getPOItems('pending').length }) }}
</ion-label>
<ion-label v-else color="medium" class="ion-margin-end">
{{ translate("PENDING: ITEM", { itemsCount: getPOItems('pending').length }) }}
{{ translate("Pending: item", { itemsCount: getPOItems('pending').length }) }}
</ion-label>
</ion-item>

Expand Down Expand Up @@ -104,10 +104,10 @@

<ion-item lines="none">
<ion-text v-if="getPOItems('completed').length > 1" color="medium" class="ion-margin-end">
{{ translate("COMPLETED: ITEMS", { itemsCount: getPOItems('completed').length }) }}
{{ translate("Completed: items", { itemsCount: getPOItems('completed').length }) }}
</ion-text>
<ion-text v-else color="medium" class="ion-margin-end">
{{ translate("COMPLETED: ITEM", { itemsCount: getPOItems('completed').length }) }}
{{ translate("Completed: item", { itemsCount: getPOItems('completed').length }) }}
</ion-text>
<ion-button v-if="getPOItems('completed').length" @click="showCompletedItems = !showCompletedItems" fill="clear">
<ion-icon :icon="showCompletedItems ? eyeOutline : eyeOffOutline"/>
Expand Down

0 comments on commit b2199fe

Please sign in to comment.