Implemented: functionality which allows users to manually close purchase order items when they receive them. (#212) #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase order items when they receive them (hotwax#212)
amansinghbais
changed the title
alsoK2maan
suggested changes
Sep 8, 2023
amansinghbais
changed the title
alsoK2maan
suggested changes
Sep 15, 2023
alsoK2maan
suggested changes
Sep 18, 2023
alsoK2maan
suggested changes
Sep 20, 2023
alsoK2maan
suggested changes
Sep 20, 2023
alsoK2maan
suggested changes
Oct 10, 2023
alsoK2maan
suggested changes
Oct 12, 2023
alsoK2maan
approved these changes
Oct 17, 2023
ymaheshwari1
requested changes
Oct 18, 2023
ymaheshwari1
requested changes
Oct 18, 2023
| import { defineComponent } from 'vue'; | ||
| import { mapGetters, useStore } from 'vuex' | ||
| import { OrderService } from "@/services/OrderService"; | ||
| import { productHelpers, showToast } from '@/utils'; |
There was a problem hiding this comment.
Remove unwanted imports.
| <ion-list-header>{{ $t("To close the purchase order, select all.") }}</ion-list-header> | ||
| </ion-item> | ||
| <ion-list> | ||
| <ion-item :button="!isPOItemStatusPending(item) ? false : true" v-for="(item, index) in getPOItems()" :key="index" @click="item.isChecked = !item.isChecked"> |
There was a problem hiding this comment.
There is no need for ternary operator, as isPOItemStatusPending will return boolean only.
ymaheshwari1
requested changes
Oct 18, 2023
| async updatePOItemStatus() { | ||
| // Shipment can only be created if quantity is specified for atleast one PO item. | ||
| if(this.isEligibileForCreatingShipment) { | ||
| const eligibleItemsForCreatingShipment = this.order.items.filter((item: any) => item.quantityAccepted > 0) |
There was a problem hiding this comment.
Suggested change
| const eligibleItemsForCreatingShipment = this.order.items.filter((item: any) => item.quantityAccepted > 0) | |
| const eligibleItemsForShipment = this.order.items.filter((item: any) => item.quantityAccepted > 0) |
ymaheshwari1
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #212
Short Description and Why It's Useful
Users can currently only receive inventory for purchase orders; there is no manual control for users to close the PO items. When the promise date arrives, the PO automatically expires. Here implemented a feature where users can close all or some shipments at once.
- Receive button create shipments for the items whom quantities are changed.
- Receive and Close button create shipments and then close the items which are selected from the "closePurchaseOrder" modal.
Screenshots of Visual Changes before/after (If There Are Any)
Before
After
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance