Added Pointer on Hover for Completed Items Icon #275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -109,7 +109,9 @@ | |||
| <ion-text v-else color="medium" class="ion-margin-end"> | |||
| {{ $t("COMPLETED: ITEM", { itemsCount: getPOItems('completed').length }) }} | |||
| </ion-text> | |||
| <ion-button fill="clear" > | |||
There was a problem hiding this comment.
We have a click event on our ion-icon, if we wrap it in ion-button the event can't be triggered. Also UI changes a bit with ion-button.
|
Closing as handled in #286 |
R-Sourabh
added a commit
to R-Sourabh/receiving
that referenced
this pull request
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #271
Short Description and Why It's Useful
I gave a hover cursor pointer to visibility button in Purchase Order, now its easier for user visibility
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance