Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: timeZone does not gets updated for user login, removed confirm alert, and added loading state #280

Merged
merged 7 commits into from
Feb 21, 2024
Prev Previous commit
Next Next commit
Improved: syntax for if and p tag
amansinghbais committed Nov 15, 2023

Verified

This commit was signed with the committer’s verified signature.
pingsutw Kevin Su
commit 16e58ae8e15d5e0cec183203e61c7afdf216b896
2 changes: 1 addition & 1 deletion src/store/modules/user/actions.ts
Original file line number Diff line number Diff line change
@@ -186,7 +186,7 @@ const actions: ActionTree<UserState, RootState> = {
/**
* Update user timeZone
*/
async setUserTimeZone( { state, commit }, payload) {
async setUserTimeZone({ state, commit }, payload) {
const current: any = state.current;
if(current.userTimeZone !== payload.tzId) {
const resp = await UserService.setUserTimeZone(payload)
4 changes: 2 additions & 2 deletions src/views/TimezoneModal.vue
Original file line number Diff line number Diff line change
@@ -17,12 +17,12 @@
<form @keyup.enter="setUserTimeZone">
<div class="empty-state" v-if="isLoading">
<ion-spinner name="crescent" />
<p>{{ $t("Fetching TimeZones")}}</p>
<p>{{ $t("Fetching TimeZones") }}</p>
</div>

<!-- Empty state -->
<div class="empty-state" v-else-if="filteredTimeZones.length === 0">
<p>{{ $t("No time zone found")}}</p>
<p>{{ $t("No time zone found") }}</p>
</div>

<!-- Timezones -->
Loading