-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed: scanning failure issue caused by empty quantity values when scanning barcode #308 #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ritika-Patel08
changed the title
Fixed scanning failure issue caused by empty quantity values (removing 0) when scanning barcode and added toast message when product not found #308
Fixed: scanning failure issue caused by empty quantity values (removing 0) when scanning barcode and added toast message when product not found #308
Feb 13, 2024
Ritika-Patel08
changed the title
Fixed: scanning failure issue caused by empty quantity values (removing 0) when scanning barcode and added toast message when product not found #308
Fixed: scanning failure issue caused by empty quantity values when scanning barcode #308
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check if we need to handle this case for other pages.
…uct as an integer, avoiding concatenation errors
…Int in false condition and added space inside find()
ymaheshwari1
requested changes
Feb 19, 2024
…anning barcode in 'Returns'
ymaheshwari1
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #308
Short Description and Why It's Useful
Resolved scanning failure caused by empty quantity fields by implementing automatic quantity update when scanning barcodes added toast message display for unavailable products to enhance user feedback.
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance