Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toast message change #363

Merged
merged 6 commits into from
Mar 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
"Location": "Location",
"Failed to receive shipment": "Failed to receive shipment",
"Failed to receive some of the items": "Failed to receive some of the items",
"Failed to scan:": "Failed to scan: {itemName}",
"Failed to update product identifier preference": "Failed to update product identifier preference",
"facility location": "facility location",
"Facility locations were not found corresponding to destination facility of return shipment. Please add facility locations to avoid receive return shipment failure.": "Facility locations were not found corresponding to destination facility of return shipment. Please add facility locations to avoid receive return shipment failure.",
Expand Down Expand Up @@ -89,6 +88,7 @@
"Scan ASN to start receiving": "Scan ASN to start receiving",
"Scan barcodes to receive them": "Scan barcodes to receive them",
"Scan items": "Scan items",
"Scanned item is not present within the shipment:": "Scanned item is not present within the shipment: {itemName}",
"Scanned successfully.": "Scanned {itemName} successfully.",
"secondary identifier": "secondary identifier",
"Search": "Search",
Expand Down Expand Up @@ -127,4 +127,4 @@
"Version: ": "Version: {appVersion}",
"You do not have permission to access this page": "You do not have permission to access this page",
"ZeroQuantity": "ZeroQuantity"
}
}
2 changes: 1 addition & 1 deletion src/store/modules/order/actions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
commit(types.ORDER_CURRENT_UPDATED, state.current )
showToast(translate("Scanned successfully.", { itemName: payload }))
} else {
showToast(translate("Failed to scan:", { itemName: payload }))
showToast(translate("Scanned item is not present within the shipment:", { itemName: payload }))
}
},
async addOrderItem ({ commit }, payload) {
Expand Down Expand Up @@ -111,7 +111,7 @@
}
return resp;
},
async createPurchaseShipment({ commit }, payload) {

Check warning on line 114 in src/store/modules/order/actions.ts

View workflow job for this annotation

GitHub Actions / call-workflow-in-another-repo / reusable_workflow_job (18.x)

'commit' is defined but never used

Check warning on line 114 in src/store/modules/order/actions.ts

View workflow job for this annotation

GitHub Actions / call-workflow-in-another-repo / reusable_workflow_job (20.x)

'commit' is defined but never used
let resp;
try {
const params = {
Expand Down
4 changes: 2 additions & 2 deletions src/store/modules/return/actions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const actions: ActionTree<ReturnState, RootState> = {
commit(types.RETURN_CURRENT_UPDATED, state);
showToast(translate("Scanned successfully.", { itemName: payload }))
} else {
showToast(translate("Failed to scan:", { itemName: payload }))
showToast(translate("Scanned item is not present within the shipment:", { itemName: payload }))
}
},
async setCurrent ({ commit, state }, payload) {
Expand Down Expand Up @@ -199,4 +199,4 @@ const actions: ActionTree<ReturnState, RootState> = {
}
}

export default actions;
export default actions;
2 changes: 1 addition & 1 deletion src/store/modules/shipment/actions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
commit(types.SHIPMENT_CURRENT_UPDATED, state);
showToast(translate("Scanned successfully.", { itemName: payload }))
} else {
showToast(translate("Failed to scan:", { itemName: payload }))
showToast(translate("Scanned item is not present within the shipment:", { itemName: payload }))
}
},
async setCurrent ({ commit }, payload) {
Expand Down Expand Up @@ -94,7 +94,7 @@
return Promise.reject(new Error(err))
}
},
receiveShipmentItem ({ commit }, payload) {

Check warning on line 97 in src/store/modules/shipment/actions.ts

View workflow job for this annotation

GitHub Actions / call-workflow-in-another-repo / reusable_workflow_job (18.x)

'commit' is defined but never used

Check warning on line 97 in src/store/modules/shipment/actions.ts

View workflow job for this annotation

GitHub Actions / call-workflow-in-another-repo / reusable_workflow_job (20.x)

'commit' is defined but never used
return Promise.all(payload.items.map(async (item: any) => {
if(!item.locationSeqId) {
return Promise.reject("Missing locationSeqId on item")
Expand Down
Loading