Improved: Show Completed Shipments Along with Open Shipments (#380) #381
Conversation
| @media (min-width: 991px) { | ||
| ion-header > div { | ||
| display: flex; |
There was a problem hiding this comment.
@amansinghbais why not use the same pattern as job manager?
There was a problem hiding this comment.
@dt2patel sir, The same pattern was used in the pipeline page of Job Manager app. Took reference from there only.
| @@ -104,7 +122,7 @@ export default defineComponent({ | |||
| const payload = { | |||
| "inputFields": { | |||
| "destinationFacilityId": this.user.facilityId, | |||
| "statusId": "PURCH_SHIP_SHIPPED", | |||
| "statusId": this.selectedSegment === "open" ? "PURCH_SHIP_SHIPPED" : "PURCH_SHIP_RECEIVED", | |||
There was a problem hiding this comment.
Should this be available on all pages instead of just the shipments page? I think so right? @amansinghbais
There was a problem hiding this comment.
Yes, we can extend this approach to other pages as well to ensure consistency across the application. Initially, the implementation was focused on the shipment page as discussed, but we can apply the same for other pages as well.
…ails page respectively (hotwax#380)
| @@ -71,20 +71,6 @@ const actions: ActionTree<OrderState, RootState> = { | |||
| async getOrderDetail({ commit, state }, { orderId }) { | |||
| let resp; | |||
|
|
|||
| const current = state.current as any | |||
There was a problem hiding this comment.
This code is removed to fetch the data every time when we go to detail page, right?
There was a problem hiding this comment.
Yes, so as to avoid old item status issue due to slow Solr updation.
src/views/ReturnDetails.vue
Outdated
| if(!this.isReturnReceivable(current.statusId)) { | ||
| showToast(translate("This return has been and cannot be edited.", { status: current?.statusDesc?.toLowerCase() })); | ||
| } | ||
| console.log(this.current); |
There was a problem hiding this comment.
Is this console log intentional?
There was a problem hiding this comment.
No, this is left by mistake, Reverted.
src/views/PurchaseOrderDetail.vue
Outdated
| this.lastScannedId = '' | ||
| }, 3000) | ||
| } else { | ||
| showToast(translate("Scanned item is not present within the shipment:", { itemName: this.queryString })); |
There was a problem hiding this comment.
"Searched item...." instead of "Scanned item...."
Related Issues
#380
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
Before
After
Contribution and Currently Important Rules Acceptance