-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code to work with Dioxus 0.6.1 #6
Conversation
Hi, thanks for your PR! I'm pretty finicky about my projects (see this blog post for details), so I rarely merge a PR as-is. I can move forward on your PR in one of two ways:
Please let me know which approach you'd prefer. If I don't hear from you before I get around to working on this PR I'll go with option 1. Thanks again for your contribution! |
Sorry for the conflicts. I realized that CI was totally broken so I fixed that in |
454275f
to
8b8576e
Compare
I'm fine with either option. I started rebasing, but ran into conflicts. I probably won't get to this for a bit so feel free to rebase or I'll get to it when I can. |
Thanks for this. I got this updated to work with my recent changes and released version 0.4.0 of this crate. |
Sounds good, thanks! |
This builds on top of @gtrak's commit here.