-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore HPC content, remove Carpentries content #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good set of revisions to help the HPC lesson stand alone Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this is really nice trimming of the site. I'd be concerned that it's a bit too agressive in some parts and removes some useful templates that we could use in the future.
Thank you for the feedback, @reid-a and @ocaisa. Before responding to the individual comments, I want to summarize my mindset when I made these sweeping, often deep-cutting, changes. HPC Carpentry is a nascent organization, and we aspire to join The Carpentries. It remains to be seen whether that will occur, and if it does, on what timeline. With that in mind:
|
I think I concur with @tkphd that, when we become official, we'll want to match up with the then-current Carpentries scheme, which may not match the material that's been removed here. FWIW. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think removing comments that potentially provide people with quick and useful information increases the maintenance effort rather than reduces it. I'm not sure it is so realistic to believe that anyone editing this repo will automatically cross-reference with the upstream site.
Valid points, @ocaisa, thank you for the patient replies. I will revise. |
For fellow travelers, the back-and-forth between @ocaisa (who originally ported this website, and is the expert) and myself (not a Jekyll noob either) is a healthy exchange, and at the end, we'll have a better website for it. This is why we have pull requests and peer review, rather than making changes to the production website directly. Plus, it looks like this has spurred some awesome upgrades -- much appreciated, Alan! |
OK, @ocaisa! I've done my best to resolve your detailed comments & objections. Site build locally, and now displays our shared Google Calendar and presents @megan-guidry as our Regional Coordinator for New Zealand. Let me know what you think. |
_config.yml
Outdated
- data: badges_stats | ||
json: 'https://feeds.carpentries.org/badges_stats.json' | ||
# - data: community_lessons | ||
# json: 'https://feeds.carpentries.org/community_lessons.json' | ||
- data: community_lessons |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment this is a manually curated file (but that will change with #25) so this needs to remain commented out or we will pull in all the Carpentries Incubator information
This is great, thanks a lot for spending so much time on it @tkphd ! |
Of course, @ocaisa -- happy to do my part! |
This PR aims to remove material specific to The Carpentries, such as institutional sponsors and donation opportunities, and replace boilerplate or Carpentries-specific copy with HPC Carpentry equivalents.
The table enumerating HPC Carpentry lessons has been restored.
The Help Wanted page has been filtered to only show issues from HPC Carpentry lessons.