test_multiple_syncs.sh: verify sequential syncs change nothing #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbonneau1
reviewed
Jan 7, 2025
ofaaland
force-pushed
the
b-rsync-tests-3
branch
from
5c2b395 to
bccee3f
Compare
|
@carbonneau1 I modified the test so the lines are all <= 80 chars wide except for a couple that are 83 chars wide. I also found there was a bug in the rsync |
|
Hi @carbonneau1 please review this updated version of the PR, thanks |
carbonneau1
reviewed
Jan 21, 2025
| rm -fr $DSYNC_SRC/stuff | ||
| rm -fr $DSYNC_DEST/stuff | ||
| mkdir $DSYNC_SRC/stuff | ||
| ${MFU_TEST_BIN}/dfilemaker -d 5-10 -n 100-300 -s 1MB-10MB $DSYNC_SRC/stuff |
There was a problem hiding this comment.
I see you generate the test data set with dfilemaker but you cal the same line from 183 and 191?
You delete the data test set once completed.
There was a problem hiding this comment.
Good point, no need to generate source data over and over again. Fixed to only generate source data once.
Test multiple dsyncs, and test dsync against rsync. 1. Running dsync twice, the second time no changes should be reported. 2. Running rsync followed by dsync, the dsync should report no changes. 3. Running dsync followed by rsync, the rsync should report no changes. rsync is run with -av -HAX to copy hard links, ACLs, and xattrs. However, the test data copied is created with dfilemaker, which does not create ACLs or xattrs, or named pipes, and may not create files with multiple hard links. This should be improved. Signed-off-by: Olaf Faaland <[email protected]>
ofaaland
force-pushed
the
b-rsync-tests-3
branch
from
bccee3f to
369addb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test multiple dsyncs, and test dsync against rsync.
rsync is run with -av -HAX to copy hard links, ACLs, and xattrs.
However, the test data copied is created with dfilemaker, which does not create ACLs or xattrs, and may not create files with multiple hard links. This should be improved.