Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#32064] Refactor the code structure #10

Closed

Conversation

RohithSurya
Copy link
Collaborator

@RohithSurya RohithSurya commented Jun 17, 2024

Fixes (#32064)[https://hpccsystems.atlassian.net/browse/HPCC-32064]

Type of change: Feature

Description

Refactor the code structure.

Checklist

  • Did I make sure I wrote the tests if I have implemented new functionality?
  • Did I make sure the test coverage meets the guidelines specified in CONTRIBUTING.md?
  • Did I lint and format the code?

Copy link

Hi @RohithSurya, thank you for your interest in contributing to PyHPCC!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]
  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

@RohithSurya RohithSurya changed the title Code structure refactor [#32064] Make bash_runcommand in WorkUnitSubmit class configurable Jun 17, 2024
Copy link

Hi @RohithSurya, thank you for your interest in contributing to PyHPCC!
However, your PR does not appear to follow our contribution guidelines:

  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

1 similar comment
Copy link

Hi @RohithSurya, thank you for your interest in contributing to PyHPCC!
However, your PR does not appear to follow our contribution guidelines:

  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

@RohithSurya RohithSurya changed the title [#32064] Make bash_runcommand in WorkUnitSubmit class configurable [#32064] Refactor the code structure Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant