Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename classes, variables and methods according to PEP-8 conventions #7

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

RohithSurya
Copy link
Collaborator

  • Make variables and function names snake case.
  • Make class names camel-case

@RohithSurya RohithSurya force-pushed the features/32026-pep8 branch from 553e3ea to 3c8e816 Compare June 13, 2024 18:00
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
960 430 45% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
pyhpcc/models.py 37% 🟢
pyhpcc/roxie_binder.py 11% 🟢
pyhpcc/utils.py 14% 🟢
tests/test_hpcc_api.py 56% 🟢
TOTAL 30% 🟢

updated for commit: 3c8e816 by action🐍

Copy link
Collaborator

@amila-desilva amila-desilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for implementing!

@amila-desilva amila-desilva merged commit 6a9f731 into main Jun 14, 2024
4 of 5 checks passed
@amila-desilva amila-desilva deleted the features/32026-pep8 branch August 22, 2024 15:59
amila-desilva added a commit that referenced this pull request Sep 9, 2024
Rename classes, variables and methods according to PEP-8 conventions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants