BC-6075 new test manageAccessToLearnstore #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csp175
changed the title
UzaeirKhan
requested changes
Jan 10, 2024
| @@ -33,6 +33,7 @@ class Management { | |||
| static #teamAdministrationNavigationButton = '[data-testid="Teams"]' | |||
| static #schoolAdministrationNavigationButton = '[data-testid="Schule"]' | |||
| static #studentTeamCheckbox = '[data-testid="student_team_checkbox"]' | |||
| static #LearnstoreCheckbox = '[id="studentlernstorevisibility"]' | |||
There was a problem hiding this comment.
- it should start with small letter
learnstoreCheckbox. Also change the name as well. because its confusing that this checkbox is only for student or other roles have sharing it? - IMO it should be
learningstorerather thanlearnstore. As you have class named asLearning_Storelater in the method implementation file
UzaeirKhan
requested changes
Jan 10, 2024
atlldwp
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
admin activates and deactivates students access to Learnstore
Links to Tickets or other pull requests
Changes
https://ticketsystem.dbildungscloud.de/browse/BC-6075
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Screenshots of UI changes
Approval for review