Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC 6306 adding bbb tool in nbc #178

Merged
merged 9 commits into from
Feb 2, 2024
Merged

BC 6306 adding bbb tool in nbc #178

merged 9 commits into from
Feb 2, 2024

Conversation

atlldwp
Copy link
Collaborator

@atlldwp atlldwp commented Jan 31, 2024 •
edited
Loading

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-6306

Changes

  • Added new test to add bbb tool in NBC.
  • Removed cy wait() for 'rooms_overview_api' to fix search room failing feature.
  • Some small refactoring.

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Screenshots of UI changes

Approval for review

  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@atlldwp atlldwp merged commit d9c122f into main Feb 2, 2024
1 of 2 checks passed
@atlldwp atlldwp deleted the BC-6306-adding-bbb-tool-in-nbc branch February 2, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csp175 csp175 csp175 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atlldwp @csp175