Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ffmpeg.go #675

Merged
merged 3 commits into from
Feb 18, 2024
Merged

Update ffmpeg.go #675

merged 3 commits into from
Feb 18, 2024

Conversation

Joftal
Copy link
Contributor

@Joftal Joftal commented Feb 5, 2024

规避潜在的 panic 错误

规避潜在的 panic 错误
@Joftal Joftal marked this pull request as ready for review February 5, 2024 07:29
@kira1928
Copy link
Collaborator

大佬看一下我的 PR ,没问题的话你 merge 一下我的 PR,然后我把咱俩的最终修改 merge 到这边的 master 如何?

@Joftal
Copy link
Contributor Author

Joftal commented Feb 18, 2024

大佬看一下我的 PR ,没问题的话你 merge 一下我的 PR,然后我把咱俩的最终修改 merge 到这边的 master 如何?

merge了

@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (e481cc4) 38.56% compared to head (a0ea72a) 38.45%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/recorders/recorder.go 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #675      +/-   ##
==========================================
- Coverage   38.56%   38.45%   -0.12%     
==========================================
  Files           8        8              
  Lines         695      697       +2     
==========================================
  Hits          268      268              
- Misses        411      413       +2     
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kira1928 kira1928 merged commit f4fc3f0 into hr3lxphr6j:master Feb 18, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants