Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support bilibili audio only record #679

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Conversation

ashesofdream
Copy link
Contributor

Use android api to support record bilibili live audio stream only.
Usage:
live_rooms:

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e481cc4) 38.56% compared to head (c6aab8d) 40.43%.
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #679      +/-   ##
==========================================
+ Coverage   38.56%   40.43%   +1.87%     
==========================================
  Files           8        8              
  Lines         695      695              
==========================================
+ Hits          268      281      +13     
+ Misses        411      398      -13     
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kira1928 kira1928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

主要是对 ffmpeg 的参数改动我比较担心,因为这个影响范围非常大。

)

var CommonUserAgent = requests.UserAgent(userAgent)
var AndroidBiliAgent = requests.UserAgent(androidBiliAgent)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bilibili 专用的常数就把它移动到 src/live/bilibili/bilibili.go 里吧。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

新的commit已经清除。

Comment on lines 144 to 145
"-y", "-re",
"-y",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个改动的目的可以解释一下吗?
这个参数好像是让 ffmpeg 按直播速度下载直播流,不要过快请求网络IO,造成不必要的性能浪费。
去掉它是为什么呢?

src/pkg/parser/ffmpeg/ffmpeg.go Outdated Show resolved Hide resolved
@kira1928 kira1928 merged commit 0c5e2b6 into hr3lxphr6j:master Feb 25, 2024
4 checks passed
@kira1928
Copy link
Collaborator

@ashesofdream
感谢大佬!
还有一个小问题,不是你的问题,但是影响到了你的PR,就是这个新参数和之前的 quality 一样,都不能在程序运行途中修改,就算修改后配置文件保存成功了,也会在开关任意直播间或其他会改变配置内容的操作时因为缓存没有被正确更新而覆盖掉你修改后的那些配置项。
我在本地有一个开发中的 branch 用来修复这个问题,顺便还会把b站专用的 quality 和你这次添加的 audio_only 房间参数改为默认值不会写入 yaml 文件,这样其他直播间的参数不会出现大量无关的这两个参数的默认值项。
在我本地的修复提交之前,暂时不会发布新的 release 版本,所以你的修改内容上线还需要等待一段时间,不好意思。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants