-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support bilibili audio only record #679
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #679 +/- ##
==========================================
+ Coverage 38.56% 40.43% +1.87%
==========================================
Files 8 8
Lines 695 695
==========================================
+ Hits 268 281 +13
+ Misses 411 398 -13
Partials 16 16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
主要是对 ffmpeg 的参数改动我比较担心,因为这个影响范围非常大。
src/live/consts.go
Outdated
) | ||
|
||
var CommonUserAgent = requests.UserAgent(userAgent) | ||
var AndroidBiliAgent = requests.UserAgent(androidBiliAgent) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bilibili 专用的常数就把它移动到 src/live/bilibili/bilibili.go 里吧。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
新的commit已经清除。
src/pkg/parser/ffmpeg/ffmpeg.go
Outdated
"-y", "-re", | ||
"-y", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个改动的目的可以解释一下吗?
这个参数好像是让 ffmpeg 按直播速度下载直播流,不要过快请求网络IO,造成不必要的性能浪费。
去掉它是为什么呢?
@ashesofdream |
Use android api to support record bilibili live audio stream only.
Usage:
live_rooms:
is_listening: true
audio_only: true