forked from lm-sensors/lm-sensors
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing #4
Draft
hramrach
wants to merge
15
commits into
master
Choose a base branch
from
testing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bundled strtod parses floats correctly regardless of locale, no need to reset locale around calling the parser. It should have been setting LC_CTYPE, anyway.
This will be needed for accessing data of reentrant lexer. Signed-off-by: Michal Suchanek <[email protected]>
The sensors library uses a global config that needs to be initialized and then cleaned up. Gather the config into a struct, add a version of the functions that accept the config to operate on, and use one global config internally to implement the existing interface. This is not really reentrant because the parser isn't because the number parsing isn't because locale isn't, and libc number parsing cannot be done without locale. It is sufficient for language runtimes that do user thread switching in the runtime, and don't interrupt C code. The parser won't be interrupted in those. In software that uses kernel threads a lock must be held around the init call. Signed-off-by: Michal Suchanek <[email protected]>
This reverts commit c2047fe9dabb3f10a4b8f5af7aee61e60ca2bc50.
This reverts commit 05c1d4e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.