Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ui redesign #31

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Conversation

Sefriol
Copy link

@Sefriol Sefriol commented Sep 14, 2020

Branch: UI-redesign (2020-09-14)

Full Changelog

  • Feature(Map): Changes to Map Element
    • Add functions to MapElement to enable dialog
      • Location pointer
      • reverse coordinates
      • press and hold to select coordinate
    • Add Map Dialog
  • main.qml: Add Notifications
  • main.qml: Add global locationParameters
  • Feature: New Mainpage
    • Change MainPage to Dialog
    • Use new UI elements for all inputs
    • Use global variables instead of local ones
    • Add New Dialogs for Address Search
    • Safe all information from the reittiopas API
    • Remove immeadiate search from ResultPage search
    • Add ResultPage to MainPage's acceptDestination
  • Mainpage: Use Favorites and RecentItems.
  • Mainpage: remove reverse favorite route button
  • Remove infobanner (use notification)
  • Separate RoutePlanner from MainPage
  • Use ExpandingBottomDrawer for FavoriteRoutes
  • MapDialog: clear model when selected coord changes
  • Add model to SuggestionDelegate
  • Add Stop times back to StopPage
    • Causes digitransit query to take longer
      • GraphQL requires all stoptimes to be queried per stop
  • Add more helper functions
  • Change Database interactions
    • There is now a schema checker incase updates are needed for tables
    • Favorites now store more information
    • Recentitems now store more information
    • Use Suggestion Delegate in Favorite / RecentItem selection
    • Favorite and Recent items are now processed as objects
  • Improve some database functions and fix bugs
    • Schema columns are now objects
    • Check column from schema in insert
    • Revert recentItems select order
  • Add clips for SilicalistViews in FavRecItemSelect
  • Reittiopas.js: Use Pattern instead of ServiceDate
    • Many lines operate out of date boundaries (leave next / previous day)
    • check whether stoptime exists
  • Move most of the common variables to main.qml
    • Move models used in multiple files
    • Rename setRouteParameters to setSearchParameters
    • Move setSearchParameters to main.qml
  • Improve Legs processing
    • No longer double for loop for generating Route string
    • Modify start and end points within reittiopas.js
    • Fix Stoptimes in StopDelegate
  • CoverPage: Complete Redesign
    • No longer strings presenting routes
    • 90% of the main functionality can now be used via Cover
      • Choose Favorite Route, Search, Select, go back
    • Unlimited Cover Favorites!
  • RoutePlanner: Add Press&Hold for all ContextMenus
  • FavoritesPage: Rename vars based on model changes
  • ResultPage: Add header update function
    • When clicking previous and next, header will also update
  • Remove some aspect related to old UI
    • Mainpage
      • Favorite limit error
      • Add to Cover (all favorites are now in cover)
    • SettingsPage
      • Search Button does not exist anymore
    • CoverPage
      • Unnecessary code
    • AboutDialog
      • Rename to About and put it under dialogs
    • StartupDialog
      • Rema,ed to Startup and moved under dialogs
    • FavoritesPage
      • Modify AddFavoriteDialog. Rename it ManageFavorite
      • Put ManageFavorite under dialogs
      • Remove EditFavoriteDialog (replaced by ManageFavorite)
    • LocationEntry
      • Removed
    • RecentItemDelegate
      • Removed
  • Favorites: Minor UI Layout tweaks
    • Also a fix for TextField clear not working
  • Mainpage: Add Drawer optimizations
    • disappear when pulldown
    • Limit startpoint changes

Sefriol added 26 commits August 20, 2020 18:46
- Add functions to MapElement to enable dialog
    * Location pointer
    * reverse coordinates
    * press and hold to select coordinate
- Add Map Dialog
- Change MainPage to Dialog
- Use new UI elements for all inputs
- Use global variables instead of local ones
- Add New Dialogs for Address Search
- Safe all information from the reittiopas API
- Remove immeadiate search from ResultPage search
- Add ResultPage to MainPage's acceptDestination
- Causes digitransit query to take longer
    * GraphQL requires all stoptimes to be queried per stop
- There is now a schema checker incase updates are needed for tables
- Favorites now store more information
- Recentitems now store more information
- Use Suggestion Delegate in Favorite / RecentItem selection
- Favorite and Recent items are now processed as objects
- Schema columns are now objects
- Check column from schema in insert
- Revert recentItems select order
- Many lines operate out of date boundaries (leave next / previous day)
- check whether stoptime exists
- Move models used in multiple files
- Rename setRouteParameters to setSearchParameters
- Move setSearchParameters to main.qml
- No longer double for loop for generating Route string
- Modify start and end points within reittiopas.js
- Fix Stoptimes in StopDelegate
- No longer strings presenting routes
- 90% of the main functionality can now be used via Cover
    * Choose Favorite Route, Search, Select, go back
- Unlimited Cover Favorites!
- When clicking previous and next, header will also update
- Mainpage
    * Favorite limit error
    * Add to Cover (all favorites are now in cover)
- SettingsPage
    * Search Button does not exist anymore
- CoverPage
    * Unnecessary code
- AboutDialog
    * Rename to About and put it under dialogs
- StartupDialog
    * Rema,ed to Startup and moved under dialogs
- FavoritesPage
    * Modify AddFavoriteDialog. Rename it ManageFavorite
    * Put ManageFavorite under dialogs
    * Remove EditFavoriteDialog (replaced by ManageFavorite)
- LocationEntry
    * Removed
- RecentItemDelegate
    * Removed
- Also a fix for TextField clear not working
- disappear when pulldown
- Limit startpoint changes
@Sefriol
Copy link
Author

Sefriol commented Sep 14, 2020

Made a video of some of the UI elements in action.

A lot of things to cover. I started this work originally years ago and decided to finish it couple of weeks ago.

Features:

  1. Mostly rewritten components to support one handed use and Sailfish principles of being able to use application with one hand.
  2. Add back some of the features that were disabled over time (like station stop times)
  3. Reuse same components for similar things (For example, SuggestionDelegate is now used by 3 different pages) to provide consistency!
  4. Store more information about the addresses into database to provide more information about the location (like city, location type etc). Also add functionality to update the database schema in the future if more information is needed!
  5. Completely rewritten cover to allow whole app operation within the cover itself!
  6. Allow Address selection from a map
  7. Use native Notification system for app notifications.
  8. Use mainly appwide global attributes, so that updating location information becomes more clear!

Still open for feedback and improvement. Some of the changes are just my personal taste, but I think there is quite a lot that app would benefit from.

Some of the components looks are quite WIP, but I thought it would be nice to get some feedback before I work more on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant