Fix version import #112
Draft
Fix version import #112
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flabbamann
force-pushed
the
version-import
branch
from
29d5773 to
d7925ec
Compare
mib1185
requested changes
Jan 25, 2025
| from version import __version__ | ||
| except ImportError: | ||
| __version__ = "dev" | ||
| from .__version__ import __version__ | ||
|
|
||
| from pyfritzhome import Fritzhome |
There was a problem hiding this comment.
Suggested change
| from pyfritzhome import Fritzhome | |
| from pyfritzhome import Fritzhome, __version__ |
| from version import __version__ | ||
| except ImportError: | ||
| __version__ = "dev" | ||
| from .__version__ import __version__ |
There was a problem hiding this comment.
Suggested change
| from .__version__ import __version__ |
Comment on lines
+1
to
+3
| """The fritzhome version.""" | ||
|
|
||
| __version__ = "0.6.13" |
There was a problem hiding this comment.
Suggested change
| """The fritzhome version.""" | |
| __version__ = "0.6.13" |
remove the file
Comment on lines
3
to
+6
| from .errors import InvalidError, LoginError, NotLoggedInError | ||
| from .fritzhome import Fritzhome | ||
| from .fritzhomedevice import FritzhomeDevice | ||
| from .__version__ import __version__ # noqa: F401 |
There was a problem hiding this comment.
Suggested change
| from .errors import InvalidError, LoginError, NotLoggedInError | |
| from .fritzhome import Fritzhome | |
| from .fritzhomedevice import FritzhomeDevice | |
| from .__version__ import __version__ # noqa: F401 | |
| try: | |
| from importlib.metadata import version | |
| __version__ = version(__name__) | |
| except ImportError: | |
| __version__ = "dev" | |
| from .errors import InvalidError, LoginError, NotLoggedInError | |
| from .fritzhome import Fritzhome | |
| from .fritzhomedevice import FritzhomeDevice |
| @@ -1,6 +1,6 @@ | |||
| [metadata] | |||
| name = pyfritzhome | |||
| version = 0.6.13 | |||
| version = attr: pyfritzhome.__version__ | |||
There was a problem hiding this comment.
Suggested change
| version = attr: pyfritzhome.__version__ | |
| version = 0.6.13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor import of current project version.