Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1332 - Specify empty domain attribute handling. #1709

Merged
merged 3 commits into from
Oct 8, 2021
Merged

Fixes #1332 - Specify empty domain attribute handling. #1709

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78e6e1f
Issue #1332 - Specify empty domain attribute handling.
miketaylr Oct 4, 2021
be91898
Issue #1332 - Address review feedback
miketaylr Oct 5, 2021
85c6aef
Issue #1332 - Changelog update
miketaylr Oct 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions draft-ietf-httpbis-rfc6265bis.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1250,17 +1250,10 @@ user agent MUST process the cookie-av as follows.
If the attribute-name case-insensitively matches the string "Domain", the user
agent MUST process the cookie-av as follows.

1. If the attribute-value is empty, the behavior is undefined. However, the
user agent SHOULD ignore the cookie-av entirely.
1. Let cookie-domain be the attribute-value.

2. If the first character of the attribute-value string is %x2E ("."):

1. Let cookie-domain be the attribute-value without the leading %x2E
(".") character.

Otherwise:

1. Let cookie-domain be the entire attribute-value.
2. If cookie-domain starts with %x2E ("."), let cookie-domain be cookie-domain
without its leading %x2E (".").

3. Convert the cookie-domain to lower case.

Expand Down Expand Up @@ -2424,6 +2417,9 @@ The "Cookie Attribute Registry" should be created with the registrations below:
* No longer treat horizontal tab as a control character:
<https://github.com/httpwg/http-extensions/pull/1589>

* Specify empty domain attribute handling:
<https://github.com/httpwg/http-extensions/pull/1709>

# Acknowledgements
{:numbered="false"}
RFC 6265 was written by Adam Barth. This document is an update of RFC 6265,
Expand Down