New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove excess_inventory from purchase_cost calculation (fixes #26) #41

Open

joefarrington wants to merge 1 commit into hubbs5:master from joefarrington:fix_Newsvendor

joefarrington commented Dec 14, 2024

Fixes #26 , removing excess_inventory from the calculation of the purchase cost in the Newsvendor environment.

This change makes the or-gym version consistent with the original implementation by Balaji et al, in which the corresponding line is:

purchase_cost = self.gamma ** self.l * c * buys

(see https://github.com/awslabs/or-rl-benchmarks/blob/master/News%20Vendor/src/news_vendor_environment.py, their self.l is the lead time, c is the purchase cost and buys is the order quantity).


          Remove excess_inventory from purchase_cost calculation

5e2b2f6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet