Add/lstm direction #2455
Merged
Add/lstm direction #2455
+25
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurentMazare
approved these changes
Sep 30, 2024
|
Thanks! |
|
Btw if you already have some models that use a bidirectional LSTM, would be great to have them as potential examples in candle-examples. |
EricLBuehler
pushed a commit
to EricLBuehler/candle
that referenced
this pull request
Nov 26, 2024
* add: direction for lstm layer * lint: remove unused Error import * refactor: remove unnecessary int assignment to Direction enum: * refactor: use &'static str type instead of String for direction_str: * Run cargofmt. --------- Co-authored-by: Laurent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added a direction field to the
LSTMConfigusing a enum for forward and reverse direction. I added this so that it's possible to retrieve the weights from reversed layers of a pretrained pytorch model. This also addresses issue #2351.