Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ColPali #2524

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Add ColPali #2524

merged 3 commits into from
Oct 1, 2024

Conversation

akshayballal95
Copy link
Contributor

  • Added Colpali model and example.
  • Added methods in Gemma and Paligemma to output the last hidden states without projection.

@akshayballal95 akshayballal95 changed the title Add Colpali Add ColPali Oct 1, 2024
LaurentMazare
LaurentMazare reviewed Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@LaurentMazare LaurentMazare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Could you remove the pdf document, we try to keep the repo size as small as possible so prefer not including more assets. Instead it's usually good to just add to the readme instructions a line like the following to details how to fetch a reference document.

wget http://...

candle-examples/examples/colpali/main.rs Outdated Show resolved Hide resolved
candle-transformers/src/models/paligemma.rs Outdated Show resolved Hide resolved
@LaurentMazare
Copy link
Collaborator

Thanks, could you have a look at the clippy failure? Looks all good besides this.

@LaurentMazare LaurentMazare merged commit 888d886 into huggingface:main Oct 1, 2024
8 of 10 checks passed
@LaurentMazare
Copy link
Collaborator

Thanks!

EricLBuehler pushed a commit to EricLBuehler/candle that referenced this pull request Nov 26, 2024
@akshayballal95 @EricLBuehler
Add ColPali (huggingface#2524)
e417061 
* add colpali

* cleanup

* fix clippy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurentMazare LaurentMazare LaurentMazare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akshayballal95 @LaurentMazare