Fix Slack bot not displaying error messages #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
BenjaminBossan
requested changes
Nov 1, 2023
There was a problem hiding this comment.
I think there is a logical error in how empty files are counted.
Also, I wonder what happens if there are several log files (can that happen?). In that case, empty_file will be determined by the last log file that is opened. What is the logical thing to do: Post a failure if any log file is empty, or only if all log files are empty?
| @@ -26,8 +26,7 @@ | |||
| total_num_failed += 1 | |||
| else: | |||
| passed.append([test, duration, log.name.split('_')[0]]) | |||
| if nb_lines == 0: | |||
| empty_file = True | |||
| empty_file = i == 0 | |||
There was a problem hiding this comment.
Hmm, when there is exactly one line,i would also be 0. How about inside of the loop, doing i += 1 instead of using enumerate?
|
I changed a bit the logic now, please let me know WDYT! |
BenjaminBossan
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per title, the line
nb_lines = sum(1 for _ in f)will loop over all the lines in the file and leading the next for loop to be emptycc @BenjaminBossan