DON'T MERGE This is for debugging only #1135
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that for LoRA, merging the first adapter works but merging the second adapter does not work.
@younesbelkada While debugging #1132, I wanted to isolate the error and found that it can already be reproduced on the main branch, without the changes from your PR.
I added two tests, one where the first adapter is merged, one where the second adapter is merged. The first test passes as expected, the second one fails for LoRA (it works for IA³):
PS: There is a small bug in IA³ where the active adapter attribute is not set after calling
set_adapter
, but that's not really related to the discussed issue.EDIT: Also tested this with
merge_adapter()
instead ofmerge_and_unload
, but that doesn't change the outcome.