Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core / LoRA] Add adapter_names in bnb layers #1139

Merged
merged 2 commits into from
Nov 16, 2023
Merged

[core / LoRA] Add adapter_names in bnb layers #1139

merged 2 commits into from
Nov 16, 2023

Conversation

younesbelkada
Copy link
Contributor

What does this PR do?

Fixes #1138

cc @BenjaminBossan @pacman100

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 16, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

BenjaminBossan
BenjaminBossan approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this quickly. Since only LoRA bnb layers support merging for now, this should be sufficient.

@younesbelkada younesbelkada merged commit 99e1a55 into main Nov 16, 2023
11 checks passed
@younesbelkada younesbelkada deleted the younesbelkada-patch-2 branch November 16, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBossan BenjaminBossan BenjaminBossan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linear4bit.merge() got an unexpected keyword argument 'adapter_names'
3 participants
@younesbelkada @HuggingFaceDocBuilderDev @BenjaminBossan