Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: reduce CorDA memory consumption + docs #2324

Merged
merged 5 commits into from
Jan 15, 2025

Conversation

5eqn
Copy link
Contributor

@5eqn 5eqn commented Jan 13, 2025

  • Added documentation about selection of run_model sample size
  • Added documentation about memory consumption of preprocessing
  • Pruned temporary fields after preprocessing and building LoRA adapter, so that CorDA does not consume more memory during training compared to other LoRA methods

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates to the docs and the improvements to memory consumption. The changes LGTM.

Before merging, could you please fix the following line:

from peft.mapping import get_peft_model

The import is no longer valid after merging #2282. Please always import like so: from peft import get_peft_model.

@5eqn
Copy link
Contributor Author

5eqn commented Jan 14, 2025

Before merging, could you please fix the following line:

Sure, the line is fixed.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, LGTM.

@BenjaminBossan BenjaminBossan merged commit 63ae263 into huggingface:main Jan 15, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants