-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MLX model support #300
Merged
aymeric-roucher
merged 22 commits into
huggingface:main
from
g-eoj:g-eoj/mlx-model-support
Feb 12, 2025
Merged
MLX model support #300
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
d4bb38f
Add MLX model support
g-eoj aa6f075
Add MLX model test
g-eoj 662a481
Merge main and refactor
g-eoj d52ea23
Skip mlx tests if not on macOS
g-eoj 8f909a0
Fix accidental reformat
g-eoj ea960fc
Add docs
g-eoj fb2fb1f
Fix typos
g-eoj 8a36c23
Pass kwargs to base class
g-eoj 8f2b082
Merge branch 'main' into g-eoj/mlx-model-support
g-eoj 9d7b3ac
Support tool calling
g-eoj 5e1643d
Merge branch 'main' into g-eoj/mlx-model-support
g-eoj 0122378
Add tests for a single planning step
g-eoj bfc10bc
Wrap planning prompts in first step
g-eoj 4b8f97b
Merge remote-tracking branch 'origin/test-planning-step' into mac
g-eoj 0c98183
Merge remote-tracking branch 'upstream/main' into g-eoj/mlx-model-sup…
g-eoj 448390b
Remove doc changes until review
g-eoj 94f684b
Merge remote-tracking branch 'upstream/main' into g-eoj/mlx-model-sup…
g-eoj 72b8034
Merge branch 'g-eoj/mlx-model-support' into mac
g-eoj c8b4f36
Add docs and address comments
g-eoj bae882b
Merge branch 'main' into g-eoj/mlx-model-support
aymeric-roucher 9b385f8
Update docs/source/en/guided_tour.md
aymeric-roucher 0bb9cc5
Update docs/source/en/reference/models.md
aymeric-roucher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,6 +46,9 @@ mcp = [ | |
"mcpadapt>=0.0.6", | ||
"mcp", | ||
] | ||
mlx-lm = [ | ||
"mlx-lm" | ||
] | ||
openai = [ | ||
"openai>=1.58.1" | ||
] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this
tool_name_key
inTransformersModel
, what is the reason for needing it inMLXModel
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually upon inspection it seems like a good idea, let's keep it and we might set the same in
TransformersModel
later on.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found the params to be required unless I was using a logits processor and regex to force the key names in the output. Which might be a better solution overall but I have no strong opinions yet.