Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #606: Fixed wrong parameter name. toolcalling_agent.yaml st… #618

Closed
wants to merge 34 commits into from

Conversation

faev999
Copy link

@faev999 faev999 commented Feb 12, 2025

FIXES #606:

"I am trying to create a manger agent of type ToolCallingAgent, by simply modifying the multi-agents example available on the docs, but instead of a CodeAgent I use the ToolCallingAgent as the manager agent."

Error in calling team member: MultiStepAgent.__call__() missing 1 required positional    
argument: 'task'
You should only ask this team member with a correct request.
As a reminder, this team member's description is the following:
<smolagents.agents.ToolCallingAgent object at 0x000001C65D9EFE90>

Fixed wrong parameter name "task". toolcalling_agent.yaml states that the argument to be given in the call is called 'request' and not 'task'. Name also changed in test_agents.py

…ent.yaml states that the argument to be given in the call is called 'request' and not 'task'. Name also changed on agent test
@aymeric-roucher
Copy link
Collaborator

Thank you for pointing this error! The fix should be to change everything to task rather than request, that's the final parameter name used elsewhere! So here it's the prompt that's faulty, not the code.

@faev999
Copy link
Author

faev999 commented Feb 12, 2025

Thnak you, I modified the prompt file so the argument´'s name is "task" and not "request".

@faev999
Copy link
Author

faev999 commented Feb 13, 2025

Sorry, I fixed the typo just now

@sysradium
Copy link
Contributor

@faev999 the PR has some conflicts now. Could you rebase please?

@faev999
Copy link
Author

faev999 commented Feb 14, 2025

Done

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@aymeric-roucher
Copy link
Collaborator

The rebasing didn't work properly? Since we're doing a release now and need a quick PR, we'll just merge #650 instead. But thank you @faev999 for highlighting the issue and proposing a fix!

@faev999
Copy link
Author

faev999 commented Feb 14, 2025

Sounds good! sorry for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Error when using ToolCallingAgent as manager